Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding kdcro101.favorites #576

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

GitMensch
Copy link
Contributor

Description

This PR introduces adds kdcro101.favorites which is currently missing and quite useful.

@GitMensch
Copy link
Contributor Author

Whatever that validation CI wants to tell me...

@filiptronicek
Copy link
Collaborator

Hi @GitMensch 👋, because the repo seems inactive since 2018, I will try to build the extension manually and publish it manually as well, so it is not present in the repo when it is not receiving any further updates.

@filiptronicek
Copy link
Collaborator

Having issues with typescript type checking, @GitMensch were you able to build the extension locally?

@GitMensch
Copy link
Contributor Author

I haven't built that in the since years.

So the point is: not adding it in the CI worker but publish once manually, correct?
Would it be reasonable in that case to use the old vsix that was published to the MS store?

@filiptronicek
Copy link
Collaborator

@GitMensch yes, we would publish once manually via a built vsix file. We don't want to use vsix files downloaded from MS as it may violate their ToS.

@GitMensch
Copy link
Contributor Author

@filiptronicek The repo got an update and I hope it will do so further - but there is zero response to the Open-VSX publishing, so I suggest to either publish it once now - as you've noted above - or add to CI.

@GitMensch
Copy link
Contributor Author

ping @filiptronicek: as it should build now can you please either approve/pull the ci change or manually push the vsix?

@filiptronicek
Copy link
Collaborator

Sorry for the delay here, @GitMensch, I have tried re-building but again it's the same issue with tsc complaining a bunch 😢.

@filiptronicek
Copy link
Collaborator

If you can build it, can you send over the instructions to build it even once so that we can publish that? I'd love if we could have the extension on Open VSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants